Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkcomposefs: make it cpuset aware #355

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

giuseppe
Copy link
Member

A tiny improvement that I've noticed while looking at the code.

use sched_getaffinity to get the CPUs that can be used.

use sched_getaffinity to get the CPUs that can be used.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. One thing I just did was a quick code search and yeah that led to the exact same code in swift.

That said I think an even nicer thing for us to consider in the future is support for the GNU make jobserver protocol which gives us a way to integrate with other build systems.

@cgwalters cgwalters merged commit df1517d into containers:main Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants